Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize halo updates to support halos of any width #69

Merged
merged 37 commits into from
Dec 1, 2023
Merged

Generalize halo updates to support halos of any width #69

merged 37 commits into from
Dec 1, 2023

Conversation

omlins
Copy link
Collaborator

@omlins omlins commented Oct 5, 2023 •
edited
Loading

Closes #68

@omlins
add halo width parameter
be0993e
@omlins
add halo width parameter and GGField
8eb82e2
@omlins
adjust unit tests to new overlaps keyword
7d373d4
@omlins
adjust unit tests to new overlaps keyword
8f6209a
@omlins
adjust unit tests to new overlaps keyword
c9a3211
@omlins
adjust unit tests to new overlaps keyword
b8aa1e7
@omlins
add unit tests for halowidth default initialization
2ac9af4
@omlins
introduce GGFieldConvertible
11ac292
@omlins
add conversion to GGField and check local halowidth
af11590
@omlins
add unit test for halo width initialization
f58fca5
@omlins
add exception tests for local halowidths
1aada57
@omlins
adapt array checks for fields
0a2472b
@omlins
introduce arrays for step by step replacement by fields
bfa8289
@omlins
generalization for fields of allocate_bufs
3e15bb7
@omlins
generalization for fields of allocate_bufs
55850b8
@omlins
generalization for fields of allocate tasks and streams
644888c
@omlins
generalization for fields of send and receive functions
dac3fdb
@omlins
use field.A for multiple dispatch of waiting functions
923bbb2
@omlins
Introduce architecture-specific field types
94c84dd
@omlins
generalization for fields of write and wait functions
7b08c9c
@omlins
enhance field types and make halosize allways 3D
78f2d1a
@omlins
generalization for fields in buffer creation, writing and send and re…
116bce3 
…ceive
@omlins
generalize halo update unit tests for fields
dc61f92
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023 •
edited
Loading

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (abcfb4c) 3.66% compared to head (d6f0413) 3.50%.

Files Patch % Lines
src/update_halo.jl 0.00% 113 Missing ⚠️
src/shared.jl 0.00% 18 Missing ⚠️
src/init_global_grid.jl 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master     #69      +/-   ##
=========================================
- Coverage    3.66%   3.50%   -0.17%     
=========================================
  Files           8       8              
  Lines         627     657      +30     
=========================================
  Hits           23      23              
- Misses        604     634      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omlins
Copy link
Collaborator Author

omlins commented Oct 5, 2023

cc @GiackAloZ @utkinis @luraess @albert-de-montserrat

@omlins omlins merged commit 6bac825 into master Dec 1, 2023
2 of 4 checks passed
@omlins omlins deleted the halowidth branch December 1, 2023 16:49
marinlauber pushed a commit to marinlauber/ImplicitGlobalGrid.jl that referenced this pull request Jul 10, 2024
@omlins
Merge pull request eth-cscs#69 from eth-cscs/halowidth
c9d6a55 
 Generalize halo updates to support halos of any width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize halo updates to support halos of any width enabling higher order methods in space
2 participants
@omlins @codecov-commenter