Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer discovery issues #62

Open
ch4r10t33r opened this issue Mar 28, 2024 · 4 comments
Open

Peer discovery issues #62

ch4r10t33r opened this issue Mar 28, 2024 · 4 comments

Comments

@ch4r10t33r
Copy link

Voltaire bundlers are unable to discover Silius peers on the network.

@Vid201
Copy link

Vid201 commented Mar 28, 2024

It would be helpful to have a test for peer connections. We could introduce a new debug endpoint debug_bundler_peers to check peers of the bundler in the test.

@sherifahmed990
Copy link
Contributor

Description for the issue:

Voltaire can discover peers when connected to a Skandha boot node "enr:-J24QG7VfzC_pWTNhbMk67-rujhFQ1xTYG3eEwb8IgH2qwESfodulOz0iPYChAoK3zaa
Kw0lf4dcvSX3Cp7CRBF3Jm-UdiGNoYWluX2lkiKc2qgAAAAAAgmlkgnY0gmlwhBKpK9OJc2VjcDI1NmsxoQMxl3O4Gr_4mZJsfkNN
HQERjURl1G-GhoyKR0NWtEK9vkoN0Y3CCEPGDdWRwghDx"

Voltaire can't discover any peers when connecting to a Silius boot node "enr:-J24QFb-3hQjofsf-BT_DphduK4QAodRn4bJP-JriJVQCTfKC73qc2Nc3s8niwRb6C5jjG8GG9DsHpfK2sLyVOhUzoQBiGNN
oYWluX2lkiKc2qgAAAAAAgmlkgnY0gmlwhII9OBqJc2VjcDI1NmsxoQKkD8kVT-qEJjEaHzokEhqhe5QpStwq0LAa5QsOYk_5foNN
0Y3CCEPGDdWRwghDx"

@shahafn
Copy link
Collaborator

shahafn commented Aug 28, 2024

@ch4r10t33r is this issue specific to the test?
@Vid201 you suggested adding a new debug endpoint, should it be part of the spec test for all bundlers? Sounds like an issue worth bringing up in the next call before we introduce it here, no?

@Vid201
Copy link

Vid201 commented Sep 16, 2024

@ch4r10t33r is this issue specific to the test? @Vid201 you suggested adding a new debug endpoint, should it be part of the spec test for all bundlers? Sounds like an issue worth bringing up in the next call before we introduce it here, no?

Yes, I think the new endpoint could be helpful for p2p tests and should be part of spec test - we could check if peers are successfully connected to each other.

Happy to discuss that on the next call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants