Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move any setStates out of componentWillMount #4

Open
ethantheman opened this issue Feb 9, 2018 · 0 comments
Open

move any setStates out of componentWillMount #4

ethantheman opened this issue Feb 9, 2018 · 0 comments

Comments

@ethantheman
Copy link
Owner

per react docs, this is an anti-pattern since setting state in componentWillMount doesn't trigger a re-render. These setState calls should be in componentDidMount or the constructor function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethantheman