Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Input: Fix incorrect byte counts in EIP-712 #357

Closed
9 tasks done
SamWilsn opened this issue Aug 26, 2024 · 4 comments
Closed
9 tasks done

Call for Input: Fix incorrect byte counts in EIP-712 #357

SamWilsn opened this issue Aug 26, 2024 · 4 comments

Comments

@SamWilsn
Copy link
Collaborator

SamWilsn commented Aug 26, 2024

Call for Input

Decision

Do we merge ethereum/EIPs#8722 ?

If Affirmed

The pull request ethereum/EIPs#8722 is merged

If Rejected

No changes made to EIP-712

Method

Rough Consensus

Deadline

September 25th, 2024

Background

See ethereum/EIPs#8722

Checklist

I, the opener of this Call for Input, have completed the following:

  • Filled in a descriptive title.
  • Filled in the "Decision" field.
  • Filled in the "If Affirmed" field.
  • Filled in the "If Rejected" field.
  • Filled in the "Method" field.
  • Filled in the "Deadline" field to be thirty days from creation.
  • Added any relevant background information (or removed the section.)
  • Published a notice in writing to the usual channels frequented by EIP Editors (likely Discord.)
  • Commented on this Call for Input, clearly stating my opinion (or abstention.)
@SamWilsn
Copy link
Collaborator Author

In Favour


Grabbing a random signature from etherscan: https://etherscan.io/verifySig/257008

Checking this with Python gives:

>>> len(bytes.fromhex('466a43011085d6c9f480c044e6987462e6636e82065721525c4bbb4f8cf33cb339b4145bd90b172dc6878c690cb350256c69cbe2e88873b6b723856789d508901c'))
65

@ethcatherders ethcatherders deleted a comment Aug 27, 2024
@ethcatherders ethcatherders deleted a comment Aug 27, 2024
@ethcatherders ethcatherders deleted a comment Aug 27, 2024
@abcoathup
Copy link

I'm against (but don't have a vote).


Reviewing such a change should not be on editors, it should be on the authors. If the authors approve a fix then editors could merge. I couldn't see anything from the original authors.

@g11tech
Copy link

g11tech commented Aug 28, 2024

in favor

even though I agree with @abcoathup , this is a fairly straightforward correction that any EL dev can verify. So i am in favor of the correction.

@poojaranjan poojaranjan mentioned this issue Sep 17, 2024
23 tasks
@lightclient
Copy link

in favor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

12 participants
@lightclient @abcoathup @SamWilsn @g11tech and others