-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call for Input: Fix incorrect byte counts in EIP-712 #357
Comments
In Favour Grabbing a random signature from etherscan: https://etherscan.io/verifySig/257008 Checking this with Python gives: >>> len(bytes.fromhex('466a43011085d6c9f480c044e6987462e6636e82065721525c4bbb4f8cf33cb339b4145bd90b172dc6878c690cb350256c69cbe2e88873b6b723856789d508901c'))
65 |
I'm against (but don't have a vote). Reviewing such a change should not be on editors, it should be on the authors. If the authors approve a fix then editors could merge. I couldn't see anything from the original authors. |
in favor even though I agree with @abcoathup , this is a fairly straightforward correction that any EL dev can verify. So i am in favor of the correction. |
in favor |
Call for Input
Do we merge ethereum/EIPs#8722 ?
The pull request ethereum/EIPs#8722 is merged
No changes made to EIP-712
Rough Consensus
September 25th, 2024
Background
See ethereum/EIPs#8722
Checklist
I, the opener of this Call for Input, have completed the following:
The text was updated successfully, but these errors were encountered: