Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optical feedback for timeslider #2207

Closed
Gared opened this issue Jul 27, 2014 · 7 comments
Closed

Optical feedback for timeslider #2207

Gared opened this issue Jul 27, 2014 · 7 comments
Assignees
Labels
Feature Request wontfix Wont Fix these things, no hate.

Comments

@Gared
Copy link
Member

Gared commented Jul 27, 2014

What do you think about adding some type of optical feedback when browsing pad versions? On large pads (several thousand of versions) changing to another version might take some seconds, but the user don't know that the browser is currently calculating the pad text and might try to change to another pad version (in some cases changing pad versions doesn't work anymore and you need to reload). This leads to the problem that the user thinks that the timeslider is broken.
I think it would be a good idea to add a popup/overlay as long as the pad version is being calculated.

@JohnMcLear
Copy link
Member

Yea this sounds good, I'd integrate it into #2070 which should solve a lot of load issues cc @marcelklehr

@JohnMcLear
Copy link
Member

Interesting challenge @seballot :D

@seballot
Copy link
Contributor

seballot commented May 7, 2020

We just need to display a small spinner loader, should be easy, I can have a look

@JohnMcLear
Copy link
Member

Awesome tnx

@JohnMcLear
Copy link
Member

@seballot any progress on this one btw? :D

@seballot
Copy link
Contributor

seballot commented Jun 9, 2020

mmmm, if I remember correctly I had a look, and could not reproduce the issue, even with big pads, when clicking to a revision the load of the new version was always very quick, so I did nothing... if you know where is the code which send the new text, you can do something like

-> when sending the request, change css cursor property on body
$('body').css('cursor', 'progress');
-> when the response comes in, change it back
$('body').css('cursor', 'default');

@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Wont Fix these things, no hate. label Aug 8, 2020
@stale stale bot closed this as completed Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request wontfix Wont Fix these things, no hate.
Projects
None yet
Development

No branches or pull requests

3 participants