Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run.sh doesn't escape $SCRIPTPATHs with spaces in them #2974

Closed
vitorio opened this issue May 11, 2016 · 0 comments
Closed

run.sh doesn't escape $SCRIPTPATHs with spaces in them #2974

vitorio opened this issue May 11, 2016 · 0 comments

Comments

@vitorio
Copy link

vitorio commented May 11, 2016

I'm running Etherpad from an external USB drive, which when automounted gets the path /media/My Book. bin/run.sh bombs out from this location with the error:

Started Etherpad...

module.js:340
    throw err;
          ^
Error: Cannot find module '/media/My'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:906:3

However, running node directly, e.g. node node_modules/ep_etherpad-lite/node/server.js works fine.

Adding quotes to the last line of bin/run.sh seems to fix the problem, although I'm sure there are other ways to properly escape these paths: exec node "$SCRIPTPATH/node_modules/ep_etherpad-lite/node/server.js" $*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant