Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Drop on Header breaks Page #3355

Closed
renebrain opened this issue Mar 28, 2018 · 2 comments
Closed

File Drop on Header breaks Page #3355

renebrain opened this issue Mar 28, 2018 · 2 comments

Comments

@renebrain
Copy link

renebrain commented Mar 28, 2018

When you Drag & Drop a file from your OS into the Header Element of the etherpad (see gif),it accepts the file and lets the browser open it / Or try to download it, which breaks everything for the user. Can this somehow be prevented? It happens on Linux & Windows with FF and Chrome (Haven't tested anything else) with your demo, the sandstorm demo and the primarypad demo as well.

Dropping into the text is just getting ignored by etherpad (That is the behaviour that we would expect from the header aswell)

header bug

@JohnMcLear
Copy link
Member

Dropping a file onto the browser's normal behavior is to load it and this is what you are experiencing... I don't think we have plans to integrate drag and drop uploads to the editor but will put this in as a feature request...

@renebrain
Copy link
Author

why is this closed? i don't understand. I don't want that functionality but what i can see is, that dropping into the etherpad contenteditable the drop is getting prevented, but not on the header, which means a user can break an etherpad app by accidentally dropping something on the header. shouldn't that behaviour be forbidden? What is the intention behind accepting the drop event on the header in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants