Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ep_tables4 started failing withoutany upgrade in the plugin #4885

Closed
SubhasishDey opened this issue Feb 28, 2021 · 3 comments · Fixed by #4886
Closed

ep_tables4 started failing withoutany upgrade in the plugin #4885

SubhasishDey opened this issue Feb 28, 2021 · 3 comments · Fixed by #4886

Comments

@SubhasishDey
Copy link

SubhasishDey commented Feb 28, 2021

I had a project which used ep_tables4, and that worked fine, and suddenly it starts failing with the below error

[2021-02-28 02:17:15.969] [WARN] client - Uncaught TypeError: Cannot read property '0' of undefined -- {
  errorId: 'GFO1guvRKuzjWlVOf0PS',
  type: 'Uncaught exception',
  msg: "Uncaught TypeError: Cannot read property '0' of undefined",
  url: 'http://192.168.99.100:9001/p/test',
  source: 'http://192.168.99.100:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_inner.js?callback=require.define&v=dc2a41f2',
  linenumber: 3,
  userAgent: 'Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.182 Safari/537.36',
  stack: "TypeError: Cannot read property '0' of undefined\n" +
    '    at AttributeManager.setAttributesOnRange (http://192.168.99.100:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_inner.js?callback=require.define&v=dc2a41f2:50:708)\n' +
    '    at Object.Ace2Inner.x.ace_performDocumentApplyAttributesToRange (http://192.168.99.100:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_inner.js?callback=require.define&v=dc2a41f2:3:39309)\n' +
    '    at Object.performDocApplyTblAttrToRow (eval at j (http://192.168.99.100:9001/static/js/require-kernel.js?v=dc2a41f2:10:1408), <anonymous>:5:13234)\n' +
    '    at Object.addTable (eval at j (http://192.168.99.100:9001/static/js/require-kernel.js?v=dc2a41f2:10:1408), <anonymous>:5:6128)\n' +
    '    at Object.doDatatableOptions (eval at j (http://192.168.99.100:9001/static/js/require-kernel.js?v=dc2a41f2:10:1408), <anonymous>:5:4259)\n' +
    '    at Qn (http://192.168.99.100:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=dc2a41f2:49:7520)\n' +
    '    at Object.<anonymous> (http://192.168.99.100:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=dc2a41f2:49:7948)\n' +
    '    at Object.ace_doDatatableOptions (http://192.168.99.100:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=dc2a41f2:49:1023)\n' +
    '    at eval (eval at j (http://192.168.99.100:9001/static/js/require-kernel.js?v=dc2a41f2:10:1408), <anonymous>:5:1609)\n' +
    '    at o (http://192.168.99.100:9001/javascripts/lib/ep_etherpad-lite/static/js/ace2_inner.js?callback=require.define&v=dc2a41f2:3:5925)'
}

Steps to reproduce the behavior:
Here is my docker file:

FROM etherpad/etherpad:1.8.7
RUN bin/installDeps.sh
RUN npm install ep_tables4
EXPOSE 9001
ENTRYPOINT bin/run.sh

Expected behavior
The table component should continue to work as it was.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Server (please complete the following information):

  • Etherpad version: latest / stable / 1.8.11
  • OS: Debian GNU/Linux 10 (buster)
  • Node.js version (node --version): 14.16.0
  • npm version (npm --version):6.14.11

Desktop (please complete the following information):

  • OS: [e.g. iOS] windows 10
  • Browser [e.g. chrome, safari] : chrome
  • Version [e.g. 22]: 88

Additional context
I am aware that is plugin specific, but the plugin was not changed. Any hints will be helpfull as well.

@rhansen
Copy link
Member

rhansen commented Feb 28, 2021

Does it work with a previous version of Etherpad?

@SubhasishDey
Copy link
Author

It doesnot work with previous versions(1.8.7) also now.
But was working earlier...
Not sure if any dependencies with node and npm...

@rhansen
Copy link
Member

rhansen commented Feb 28, 2021

Are you sure it doesn't work with 1.8.7? There is a bug that was introduced in 1.8.8 in that call stack from your logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants