Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click anywhere on empty pad won't open device keyboard #4928

Closed
ramonlsouza opened this issue Mar 5, 2021 · 4 comments · Fixed by #4929
Closed

Click anywhere on empty pad won't open device keyboard #4928

ramonlsouza opened this issue Mar 5, 2021 · 4 comments · Fixed by #4929
Labels

Comments

@ramonlsouza
Copy link

Describe the bug
When you have a pad with empty text on mobile devices, you need to click in the blinking cursor to open the device keyboard.

The same does not happen if you already have some text (or in older versions of Etherpad).

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://demo.etherpad.com/ (on a mobile device)
  2. Create new pad
  3. Erase all default text
  4. Close device keyboard
  5. Click anywhere on the screen except the blinking cursor
  6. Device keyboard won't open

Expected behavior
Device keyboard should open by clicking anywhere on step 6.

Server (please complete the following information):

  • Etherpad version: 1.8.7 (also happens in https://demo.etherpad.com/)
  • OS: Ubuntu 18.04
  • Node.js version (node --version): v12.21.0
  • npm version (npm --version): 6.14.11

Smartphone (please complete the following information):

  • Device: Samsung Galaxy S10e
  • OS: Android 11
  • Browser: Google Chrome
  • Version: 89.0.4389.72

Additional context
We have an older test server running Etherpad 1.8.0 and the behavior is as expected (https://etherpad.wikimedia.org/ also works as expected)

@webzwo0i
Copy link
Member

webzwo0i commented Mar 5, 2021

Thanks for reporting. Bisect says 98de2b0

@JohnMcLear
Copy link
Member

Wow good job @webzwo0i that's a decent bisect and super interesting

@rhansen
Copy link
Member

rhansen commented Mar 6, 2021

@ramonlsouza Can you try copying this line to #innerdocbody:

min-height: 100vh; /* take at least full height */

@ramonlsouza
Copy link
Author

ramonlsouza commented Mar 8, 2021

@ramonlsouza Can you try copying this line to #innerdocbody:

min-height: 100vh; /* take at least full height */

It worked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants