Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash by sending invalid changesets #752

Closed
fourplusone opened this issue Jun 3, 2012 · 1 comment
Closed

Crash by sending invalid changesets #752

fourplusone opened this issue Jun 3, 2012 · 1 comment

Comments

@fourplusone
Copy link
Contributor

Steps to reproduce:

  • open a new pad
  • paste pad.collabClient.sendMessage({"type":"USER_CHANGES","baseRev":1,"changeset":"Z:6c>1|3=51*0+1$d","apool":{"numToAttrib":{"0":["author","a.S0PQKyrRVYnlR5FW"]},"nextNum":1}}) into js console.

Crashlog:

 Error: exports: mismatched follow
    at Object.error (/private/tmp/etherpad-lite/src/static/js/Changeset.js:41:11)
    at Object.assert (/private/tmp/etherpad-lite/src/static/js/Changeset.js:55:13)
    at Object.follow (/private/tmp/etherpad-lite/src/static/js/Changeset.js:2080:11)
    at Object.callback (/private/tmp/etherpad-lite/src/node/handler/PadMessageHandler.js:454:35)
    at /private/tmp/etherpad-lite/src/node_modules/ueberDB/CloneAndAtomicLayer.js:120:17
    at /private/tmp/etherpad-lite/src/node_modules/ueberDB/CacheAndBufferLayer.js:345:7
    at /private/tmp/etherpad-lite/src/node_modules/ueberDB/CacheAndBufferLayer.js:183:7
    at [object Object].get (/private/tmp/etherpad-lite/src/node_modules/ueberDB/dirty_db.js:48:3)
    at [object Object].get (/private/tmp/etherpad-lite/src/node_modules/ueberDB/CacheAndBufferLayer.js:156:20)
    at [object Object].getSub (/private/tmp/etherpad-lite/src/node_modules/ueberDB/CacheAndBufferLayer.js:317:8)
@mrneil
Copy link
Contributor

mrneil commented Jun 18, 2012

The code I document in issue #472 solves this problem. As I wrote there, however, I do not know how valid it is and what impact (if any) it has on other operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants