Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom css for the text area #83

Closed
tomassedovic opened this issue Aug 15, 2011 · 4 comments
Closed

Custom css for the text area #83

tomassedovic opened this issue Aug 15, 2011 · 4 comments

Comments

@tomassedovic
Copy link

I tried to modify the look of my local Etherpad Lite setup yesterday. It seems that the custom/pad.css can't handle the everything -- most importantly, the editor area is in an iframe so the custom CSS can't reach it.

So I see 3 possible ways to fix this:

  1. Get rid of all the iframes. (while I'd prefer this personally, it probably won't be easy and maybe not even possible -- I didn't study the architecture yet and I presume there's a reason for using iframes)
  2. Include the static/custom/pad.css file in all the iframes -- that way it can style every element on the page.
  3. Add a new file: static/custom/iframe_editor.css that would be included in the editor iframe.

Would this feature be welcome in the project? If so, let me know what approach you prefer and I can whip up a patch later this week.

@JohnMcLear
Copy link
Member

I have done 2 and 3 and tested. Pushed changes to Pita to test, should be in todays version. I will let Pita close this once it's pulled into the master branch.

Feel free to try approach to #1, Pita may have some more insights as to why an iFrame is required..

@Pita
Copy link
Contributor

Pita commented Aug 15, 2011

I think 2 is a good solution. But this is a douple iframe, means there is again an iframe in an iframe (I don't know why they did this).

@JohnMcLear
Copy link
Member

Closed and merged

@adamjgrant
Copy link

Hmm, I'm having the same issue, but I don't see #2 or #3 implemented in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants