Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom purchasables for 'Products in Cart' notice type #7

Open
timeverts opened this issue Jan 31, 2020 · 3 comments
Open

Support custom purchasables for 'Products in Cart' notice type #7

timeverts opened this issue Jan 31, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@timeverts
Copy link

Having had a brief look at your code, it doesn't appear as though custom purchasables are supported when the notice type is 'Products in Cart'. I was wondering whether you might be willing to implement support for this as I could really use it for an upcoming project.

Some examples of custom purchasables are:

All custom purchasables extend the same craft\commerce\base\Purchasable class. The default Commerce product (which is actually a Variant) extends this class too, so it's really a custom purchasable itself.

If you want to see an example of supporting custom purchasables, take a look at the code and interface for the Promotions section in Commerce. Discounts and Sales can utilise both standard products and custom purchasables. It's should be a pretty straight forward implementation to support it since both a standard Commerce purchasable (i.e. product variant) and custom purchasable extend the same base functionality/class.

Thanks.

@timeverts
Copy link
Author

Nine months later, is there any further update on this request?

@timeverts
Copy link
Author

@Tam any update on the likely implementation of custom purchasable support?
Could really have done with this feature for a current large project.

@alexjcollins
Copy link
Member

@timeverts sorry for the embarrassingly long delay getting back to you on this request.

Honestly, it's something we'd really like to add but would probably depend on a client requiring the functionality (so we could pass the dev cost on). If the plugin was more popular or it was requested by a number of people, it may make it higher on the priority list.

If you wanted to make a PR with support for these I'd be happy to gift you a couple of free lifetime licenses

@alexjcollins alexjcollins added the enhancement New feature or request label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants