Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short name requirements #483

Open
frangio opened this issue Oct 12, 2021 · 2 comments
Open

Short name requirements #483

frangio opened this issue Oct 12, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@frangio
Copy link

frangio commented Oct 12, 2021

The shortName field is a little inconsistent right now, and a few stand out as not particularly short and with varying combinations of capitalization, spaces, and dashes. (E.g. "Telos EVM", "CELO", "Ontology Testnet", "aurora-testnet", "tpalm" with "t" prefix indicating testnet.)

I couldn't find guidelines for the correct or expected formatting, and I think it would be beneficial to standardize it a little more.

I would suggest at the very least a requirement of no spaces. On top of that, it should try to be reasonably short, thus generally not the same as the name field. The vast majority right now are lowercase and I personally think that's preferable.

I think it is implicit but could be made explicit, that the short name must be unique.

I suppose these requirements could be mentioned in the "new chain" issue template.

@ligi
Copy link
Member

ligi commented Oct 13, 2021

Good point - PRs welcome ;-)

that the shortName must be unique is enforced by the CI as it is a hard requirement for TREZOR

@github-actions
Copy link

This issue has no activity in a while - it will be closed soon.

@github-actions github-actions bot added the Stale label Feb 28, 2022
@ligi ligi added enhancement New feature or request and removed Stale labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants