feat(derive): Span Batch Validation #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
added
K-feature
|
Moving to draft since we'll need testing. It'll probably make sense to also refactor some of the internal checks into functional utilities methods for easier testing as part of this. |
refcell
force-pushed
the
refcell/span-batch-checks
branch
from
06ec9cb
to
ab8548f
Compare
|
Notice: This doesn't add full test coverage; there's a few missing. Will need to add in a follow-on pr or later if time permits. |
clabby
approved these changes
Apr 19, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements span batch validation.
Unfortunately since the fetcher is colored, we have to mark pure batch derivation methods with
async.Metadata
Fixes #120