Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Ethereum Data Source #159

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 28, 2024

Description

Fixes the ethereum data source to default to a calldata-based provider if the ecotone timestamp is not set, following the reference implementation.

Copy link
Collaborator Author

refcell commented Apr 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title fix(derive): ethereum data source fix(derive): Ethereum Data Source Apr 28, 2024
@refcell refcell requested review from clabby and N0xMare April 28, 2024 17:06
@refcell refcell added A-derive Area: kona-derive crate K-fix Kind: fix labels Apr 28, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review April 28, 2024 17:06
@refcell refcell added this to the Table Stakes milestone Apr 28, 2024
@refcell refcell self-assigned this Apr 28, 2024
@refcell refcell force-pushed the refcell/data-source-factory-fixes branch from cdb6b24 to 99cc6b3 Compare April 28, 2024 20:33
@refcell refcell requested a review from clabby April 28, 2024 20:35
@clabby clabby added this pull request to the merge queue Apr 28, 2024
Merged via the queue into main with commit eba5b50 Apr 28, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 28, 2024
This was referenced May 29, 2024
This was referenced Jun 6, 2024
This was referenced Jun 16, 2024
@clabby clabby deleted the refcell/data-source-factory-fixes branch July 2, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants