Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plasma): Plasma Data Source Cleanup #164

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 28, 2024

Description

Removes unused fields from the plasma data source.

Cleans up doc comments.

Uses the canonical block id constructor.

Copy link
Collaborator Author

refcell commented Apr 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title fix(plasma): cleanup the plasma data source fix(plasma): Plasma Data Source Cleanup Apr 28, 2024
@refcell refcell requested review from clabby and N0xMare April 28, 2024 18:31
@refcell refcell added K-chore Kind: chore K-fix Kind: fix A-plasma labels Apr 28, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review April 28, 2024 18:31
@refcell refcell self-assigned this Apr 28, 2024
@refcell refcell added this to the Table Stakes milestone Apr 28, 2024
@refcell refcell force-pushed the refcell/chore/plasma-source branch from b5a81fb to b0e6185 Compare April 28, 2024 18:33
@clabby
Copy link
Collaborator

clabby commented Apr 28, 2024

Actually, can we just put these changes in #165? Looks like these'll conflict on merge.

Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@refcell refcell force-pushed the refcell/chore/plasma-source branch from b0e6185 to 698e954 Compare April 28, 2024 20:17
@refcell refcell requested a review from clabby April 28, 2024 20:18
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid!

@clabby clabby added this pull request to the merge queue Apr 28, 2024
Merged via the queue into main with commit 4147919 Apr 28, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 28, 2024
This was referenced May 29, 2024
This was referenced Jun 6, 2024
@github-actions github-actions bot mentioned this pull request Jun 16, 2024
This was referenced Jun 16, 2024
@clabby clabby deleted the refcell/chore/plasma-source branch July 2, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-chore Kind: chore K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants