Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plasma): Reduce PlasmaSource Generic Verbosity #165

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 28, 2024

Descriptioin

Reduces the generic verbosity on the Plasma source from <CP, PIF, I> to <C, F, I>. Keeping things simple.

Copy link
Collaborator Author

refcell commented Apr 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title fix(plasma): reduce plasma source generic verbosity chore(plasma): Reduce PlasmaSource Generic Verbosity Apr 28, 2024
@refcell refcell requested review from clabby and N0xMare April 28, 2024 18:38
@refcell refcell added K-chore Kind: chore A-plasma labels Apr 28, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review April 28, 2024 18:38
@refcell refcell self-assigned this Apr 28, 2024
@refcell refcell added this to the Table Stakes milestone Apr 28, 2024
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can we port #164 into here so we can get a clean merge?

@refcell
Copy link
Collaborator Author

refcell commented Apr 28, 2024

LGTM - can we port #164 into here so we can get a clean merge?

I'll just rebase it ontop to be cleaner :) I wanted to split them all out so they'd be easier to review. Personally prefer easier reviewership over easier rebases.

@refcell refcell added this pull request to the merge queue Apr 28, 2024
Merged via the queue into main with commit c80b713 Apr 28, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 28, 2024
This was referenced May 29, 2024
This was referenced Jun 6, 2024
This was referenced Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants