feat(workspace): Client programs in workspace + entrypoint proc macro #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
clabby
changed the title
clabby
added
K-chore
clabby
force-pushed
the
cl/client-prog-in-workspace
branch
from
a79b514 to
9f07bad
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 23, 2024
Moves the client programs into the workspace, by using custom build profiles in the virtual workspace for the client binaries. This change will allow us to work on the primary client program within the workspace, without having to have loose crates. A new crate, `kona-common-proc`, has been added as an extension of `kona-common` to make clean `main` functions in client programs. The `#[client_entry(<heap_size>)]` attribute will expand to include a `_start` symbol if the binary is being compiled to a supported FPVM target. If not, it will include a `main` symbol, as normal to run on the native hardware.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Moves the client programs into the workspace, by using custom build profiles in the virtual workspace for the client binaries. This change will allow us to work on the primary client program within the workspace, without having to have loose crates. A new crate, `kona-common-proc`, has been added as an extension of `kona-common` to make clean `main` functions in client programs. The `#[client_entry(<heap_size>)]` attribute will expand to include a `_start` symbol if the binary is being compiled to a supported FPVM target. If not, it will include a `main` symbol, as normal to run on the native hardware.
clabby
force-pushed
the
cl/client-prog-in-workspace
branch
from
9f07bad to
794d1e6
Compare
This was referenced May 23, 2024
Closed
Closed
Closed
This was referenced Jun 11, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Moves the client programs into the workspace, by using custom build profiles in the virtual workspace for the client binaries.
This change will allow us to work on the primary client program within the workspace, without having to have loose crates.
kona-common-procA new crate,
kona-common-proc, has been added as an extension ofkona-commonto make cleanmainfunctions in client programs.The
#[client_entry(<heap_size>)]attribute will expand to include a_startsymbol if the binary is being compiled to a supported FPVM target. If not, it will include amainsymbol, as normal to run on the native hardware.Example