Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mpt): Trie DB commit #196

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat(mpt): Trie DB commit #196

merged 1 commit into from
Jun 4, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented May 31, 2024

Overview

Implements the TrieCacheDB's DatabaseCommit trait, recomputing the state root when commit is called using the TrieNode.

@clabby Graphite App
Copy link
Collaborator Author

clabby commented May 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby mentioned this pull request May 31, 2024
Merged
@clabby clabby added K-feature Kind: feature A-mpt Area: kona-mpt crate labels May 31, 2024
@clabby clabby force-pushed the cl/trie-updates branch from a95d8f7 to 78e9e90 Compare May 31, 2024 22:53
@clabby clabby force-pushed the cl/trie-db-commit branch from 9c75b76 to cd7cfba Compare May 31, 2024 22:53
@clabby clabby force-pushed the cl/trie-updates branch from 78e9e90 to f6bc949 Compare May 31, 2024 22:54
@clabby clabby force-pushed the cl/trie-db-commit branch from cd7cfba to d3836cb Compare May 31, 2024 22:55
@clabby clabby force-pushed the cl/trie-updates branch from f6bc949 to 1060832 Compare May 31, 2024 22:56
@clabby clabby force-pushed the cl/trie-db-commit branch from d3836cb to 785b075 Compare May 31, 2024 22:56
@clabby clabby self-assigned this May 31, 2024
@clabby clabby force-pushed the cl/trie-updates branch from 1060832 to cd5d82b Compare May 31, 2024 23:01
@clabby clabby force-pushed the cl/trie-db-commit branch from 785b075 to 3e11d2e Compare May 31, 2024 23:01
This was referenced Jun 1, 2024
Merged
Merged
@clabby clabby force-pushed the cl/trie-updates branch from cd5d82b to 94ade37 Compare June 1, 2024 22:05
@clabby clabby force-pushed the cl/trie-db-commit branch from 3e11d2e to d6c8369 Compare June 1, 2024 22:05
@clabby clabby marked this pull request as ready for review June 1, 2024 22:05
@clabby clabby force-pushed the cl/trie-db-commit branch from d6c8369 to 557784b Compare June 1, 2024 22:27
@clabby clabby mentioned this pull request Jun 2, 2024
Merged
@clabby clabby requested a review from refcell June 2, 2024 05:53
@clabby clabby force-pushed the cl/trie-db-commit branch from 557784b to 3169166 Compare June 3, 2024 22:50
@clabby clabby changed the base branch from cl/trie-updates to main June 3, 2024 22:50
@clabby clabby force-pushed the cl/trie-db-commit branch from 3169166 to 9dd36ee Compare June 3, 2024 22:56
refcell
refcell approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@refcell refcell added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 44f023d Jun 4, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Closed
@clabby clabby deleted the cl/trie-db-commit branch June 4, 2024 15:12
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Closed
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 11, 2024
This was referenced Jun 11, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-mpt Area: kona-mpt crate K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell