Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kona-derive): Updated interface #230

Merged
merged 5 commits into from
Jun 11, 2024
Merged

feat(kona-derive): Updated interface #230

merged 5 commits into from
Jun 11, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jun 10, 2024

Description

Updates the Pipeline interface to include a set_origin method and updates the reset method to perform the pipeline reset.

Copy link
Collaborator Author

refcell commented Jun 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title feat(kona-derive): pipeline output validation feat(kona-derive): Updated interface Jun 10, 2024
@refcell refcell requested a review from clabby June 10, 2024 23:18
@refcell refcell added A-derive Area: kona-derive crate K-fix Kind: fix labels Jun 10, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review June 10, 2024 23:47
@refcell refcell self-assigned this Jun 10, 2024
crates/derive/USAGE.md Outdated Show resolved Hide resolved
crates/derive/src/pipeline/builder.rs Outdated Show resolved Hide resolved
crates/derive/src/online/validation.rs Outdated Show resolved Hide resolved
crates/derive/src/online/validation.rs Outdated Show resolved Hide resolved
crates/derive/src/online/validation.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@518c8d8). Learn more about missing BASE report.

Files Patch % Lines
crates/derive/src/pipeline/core.rs 0.00% 35 Missing ⚠️
crates/derive/src/pipeline/builder.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage        ?   74.38%           
=======================================
  Files           ?       98           
  Lines           ?    10035           
  Branches        ?        0           
=======================================
  Hits            ?     7465           
  Misses          ?     2570           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell requested a review from clabby June 11, 2024 14:47
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice mr wick

crates/derive/src/online/validation.rs Outdated Show resolved Hide resolved
@refcell refcell enabled auto-merge June 11, 2024 14:59
@refcell refcell added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 9c2fa66 Jun 11, 2024
15 checks passed
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
@clabby clabby deleted the refcell/pipeline-rework branch July 2, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants