Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): Dynamic Rollup Config Loading #293

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jun 20, 2024

Description

Updates the trusted-sync example to dynamically load the rollup config based on the l1 chain id.

In the future this will be upstreamed into the superchain-registry.

Metadata

Fixes #292.

@refcell refcell added this to the Phase 5: Nice to Have milestone Jun 20, 2024
@refcell refcell requested a review from clabby June 20, 2024 22:34
@refcell refcell self-assigned this Jun 20, 2024
examples/trusted-sync/src/main.rs Outdated Show resolved Hide resolved
@refcell refcell force-pushed the refcell/dynamic-load-rollup-config branch from 5cb1f61 to ef41b8d Compare June 21, 2024 16:02
@refcell refcell requested a review from clabby June 21, 2024 16:02
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (5655e48) to head (e924063).

Files Patch % Lines
crates/derive/src/online/alloy_providers.rs 0.0% 8 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby enabled auto-merge June 21, 2024 16:07
@clabby clabby added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 916339a Jun 21, 2024
14 checks passed
This was referenced Jun 21, 2024
@clabby clabby deleted the refcell/dynamic-load-rollup-config branch July 2, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(examples): Load Rollup Config Based on L1 RPC Chain ID
3 participants