Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): Channel Reader Implementation #65

Merged
merged 8 commits into from
Apr 3, 2024
Merged

feat(derive): Channel Reader Implementation #65

merged 8 commits into from
Apr 3, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Mar 26, 2024 •
edited
Loading

Description

Implements the basic enumerable Batch type for the ChannelReader.
Implements the ChannelReader stage.

Metadata

Fixes #51

@refcell refcell self-assigned this Mar 26, 2024
@refcell refcell requested review from tynes and clabby March 26, 2024 22:46
@refcell refcell added the A-derive Area: kona-derive crate label Mar 26, 2024
@refcell refcell changed the title feat(derive): Channel Reader Batch Type feat(derive): Channel Reader Implementation Mar 29, 2024
@refcell refcell added the K-feature Kind: feature label Mar 29, 2024
@refcell refcell force-pushed the refcell/batch-type branch from f777b0e to e857519 Compare March 30, 2024 21:29
clabby
clabby requested changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Would like to get this in soon, can finish up the span batch portions and some further testing in other PRs.

crates/derive/src/stages/channel_reader.rs Show resolved Hide resolved
crates/derive/src/types/batch.rs Outdated Show resolved Hide resolved
crates/derive/src/types/batch_type.rs Outdated Show resolved Hide resolved
@refcell refcell requested a review from clabby April 3, 2024 00:01
@refcell refcell requested a review from clabby April 3, 2024 01:19
@clabby clabby merged commit 13ddfb9 into main Apr 3, 2024
13 checks passed
@clabby clabby deleted the refcell/batch-type branch April 3, 2024 01:50
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

@tynes tynes Awaiting requested review from tynes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(derivation): Channel Reader
2 participants
@refcell @clabby