Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): BatchQueue Implementation #67

Merged
merged 11 commits into from
Apr 3, 2024
Merged

feat(derive): BatchQueue Implementation #67

merged 11 commits into from
Apr 3, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Mar 29, 2024 •
edited
Loading

Description

Implements the BatchQueue.

Metadata

Fixes #52

@refcell refcell requested review from tynes and clabby March 29, 2024 21:56
@refcell refcell self-assigned this Mar 29, 2024
@refcell refcell added K-feature Kind: feature A-derive Area: kona-derive crate labels Mar 29, 2024
@refcell refcell force-pushed the refcell/batch-type branch from f777b0e to e857519 Compare March 30, 2024 21:29
@refcell refcell force-pushed the refcell/batch-queue branch from ce2e4a1 to d367951 Compare March 30, 2024 21:47
Base automatically changed from refcell/batch-type to main April 3, 2024 01:50
@refcell refcell marked this pull request as ready for review April 3, 2024 16:23
clabby
clabby reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good. The business logic in the BatchQueue seems to be correct when compared with the Go implementation.

Couple small nits, then should be good to get into trunk to keep iterating on 🚀

crates/derive/src/traits/data_sources.rs Outdated Show resolved Hide resolved
crates/derive/src/stages/batch_queue.rs Outdated Show resolved Hide resolved
crates/derive/src/stages/batch_queue.rs Outdated Show resolved Hide resolved
crates/derive/src/stages/batch_queue.rs Outdated Show resolved Hide resolved
crates/derive/src/stages/batch_queue.rs Outdated Show resolved Hide resolved
crates/derive/src/stages/batch_queue.rs Outdated Show resolved Hide resolved
crates/derive/src/stages/batch_queue.rs Outdated Show resolved Hide resolved
crates/derive/src/types/block.rs Outdated Show resolved Hide resolved
@refcell refcell requested a review from clabby April 3, 2024 18:10
@refcell refcell merged commit 2ca2031 into main Apr 3, 2024
13 checks passed
@refcell refcell deleted the refcell/batch-queue branch April 3, 2024 18:44
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Closed
This was referenced Jun 11, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

@tynes tynes Awaiting requested review from tynes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(derive): Batch Queue stage
2 participants
@refcell @clabby