Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Stage Decoupling #88

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 4, 2024

Description

Decouples stages using minimal traits.

This allows for extensible, portable testing using mock providers that implement the stage provider traits.

Also has the added benefit of reducing the number of stagewise generics.

@refcell refcell added K-chore Kind: chore A-derive Area: kona-derive crate M-tests Meta: Testing related labels Apr 4, 2024
@refcell refcell self-assigned this Apr 4, 2024
@refcell refcell requested a review from clabby April 4, 2024 17:32
@refcell refcell marked this pull request as ready for review April 4, 2024 18:35
@clabby clabby merged commit 2a4038c into main Apr 5, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@clabby clabby deleted the refcell/l1-retrieval-provider branch April 19, 2024 18:52
This was referenced May 29, 2024
This was referenced Jun 6, 2024
This was referenced Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-chore Kind: chore M-tests Meta: Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants