Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): Online ChainProvider #93

Merged
merged 5 commits into from
Apr 8, 2024
Merged

feat(derive): Online ChainProvider #93

merged 5 commits into from
Apr 8, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Apr 6, 2024 •
edited
Loading

Overview

Note

Blocked by need for TxDeposit variant in TxEnvelope.

Implements an online implementation of the ChainProvider trait, backed by an alloy RPC client. This provider is gated by the alloy-providers feature flag.

@clabby clabby added K-feature Kind: feature A-derive Area: kona-derive crate labels Apr 6, 2024
@clabby clabby self-assigned this Apr 6, 2024
@clabby clabby force-pushed the cl/online-chain-provider branch 7 times, most recently from 86d10c2 to 072309b Compare April 6, 2024 06:39
refcell
refcell reviewed Apr 8, 2024
View reviewed changes
justfile Show resolved Hide resolved
refcell
refcell reviewed Apr 8, 2024
View reviewed changes
justfile Show resolved Hide resolved
refcell
refcell requested changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the lints if possible by adding a new non-default online feature flag?

@refcell refcell added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 74a838a Apr 8, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Closed
@clabby clabby deleted the cl/online-chain-provider branch April 19, 2024 18:51
This was referenced May 29, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell