Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Move to tracing for telemetry #94

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Apr 6, 2024

Overview

Note

RFC on if we want to keep our own telemetry utils.

Moves to the tracing crate for telemetry, rather than the hand-rolled solution. The tracing crate provides simple macros and a robust collection system for traces, which can be leveraged in testing and in live environments. Because consumers of this crate, like magi and reth, use tracing, these telemetry logs will also be captured by their trace subscirbers.

In addition, trace collection can be avoided by not having a global subscriber, leaving no impact on performance in the case of the telemetry logs not being used. This will be advantageous for performance in the client program, where we want to avoid superfluous heap allocation.

@clabby clabby self-assigned this Apr 6, 2024
@clabby clabby added K-feature Kind: feature A-derive Area: kona-derive crate labels Apr 6, 2024
@clabby clabby marked this pull request as ready for review April 6, 2024 06:20
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for cleaning this up

@refcell refcell added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 56fa3ba Apr 8, 2024
13 checks passed
@clabby clabby deleted the cl/tracing-telemetry branch April 8, 2024 17:40
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
This was referenced May 29, 2024
This was referenced Jun 6, 2024
This was referenced Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants