Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): Move from RegisterSize to native ptr size type #95

Merged
merged 1 commit into from
Apr 8, 2024
Merged

feat(common): Move from RegisterSize to native ptr size type #95

merged 1 commit into from
Apr 8, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Apr 6, 2024

Overview

Removes the RegisterSize type in kona-common in favor of usize, which natively represents the pointer size of the target. https://doc.rust-lang.org/stable/std/primitive.usize.html

@clabby clabby added the A-common Area: kona-common crate label Apr 6, 2024
@clabby clabby self-assigned this Apr 6, 2024
@clabby clabby enabled auto-merge April 6, 2024 17:41
@clabby clabby added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 2dba60b Apr 8, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Closed
@clabby clabby deleted the cl/common-usize-register branch April 19, 2024 18:51
This was referenced May 29, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Closed
Closed
This was referenced Jun 16, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-common Area: kona-common crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell