Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node/rollup/derive: Investigate using a Peek/Discard io.Reader in BatchReader #10522

Open
sebastianst opened this issue May 13, 2024 · 0 comments
Labels
A-op-batcher Area: op-batcher T-protocol Team: changes to node components (op-node, op-reth, etc.) implemented by go/rust/etc. devs

Comments

@sebastianst
Copy link
Member

The BatchReader might be improved to save one buffered reader instantiation by receiving a reader with Peek and Discard functions.

It should be checked if this is feasible in all places where the BatchReader is used, and in this case do the change.

Original Conversation:

          What if we took a peekable/discard reader instead of a generic reader here? Realistically the underlying type is a bytes.Buffer

Also, what if we passed the chainspec object to the batcher reader rather than flags like the limit + isFjord (edit: We need a to pass a "chain rules" object which contains these values for the pipeline origin).

Originally posted by @trianglesphere in #10358 (comment)

@BlocksOnAChain BlocksOnAChain added the T-protocol Team: changes to node components (op-node, op-reth, etc.) implemented by go/rust/etc. devs label Jun 21, 2024
@geoknee geoknee added the A-op-batcher Area: op-batcher label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-batcher Area: op-batcher T-protocol Team: changes to node components (op-node, op-reth, etc.) implemented by go/rust/etc. devs
Projects
None yet
Development

No branches or pull requests

3 participants