Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unaligned futex addresses #11650

Closed
mbaxter opened this issue Aug 27, 2024 · 0 comments · Fixed by #11929
Closed

Handle unaligned futex addresses #11650

mbaxter opened this issue Aug 27, 2024 · 0 comments · Fixed by #11929
Assignees
Labels
A-cannon Area: cannon

Comments

@mbaxter
Copy link
Contributor

mbaxter commented Aug 27, 2024

Description

Following up on #11605, we should add additional tests that validate FPVM behavior when a futex operation has an unaligned address argument (argument a0 here).

Currently, the VM will panic when we try to access unaligned memory, but we should consider either silently aligning the futex address argument as we do for memory reads and writes, or else explicitly panicking if this address is not aligned.

@Inphi Inphi transferred this issue from another repository Aug 28, 2024
@Inphi Inphi transferred this issue from ethereum-optimism/temporary-issue-migration Aug 28, 2024
@Inphi Inphi added the A-cannon Area: cannon label Aug 28, 2024
@mbaxter mbaxter self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cannon Area: cannon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants