Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM Engineering: Change CI pattern for contracts checks #11722

Closed
mds1 opened this issue Sep 3, 2024 · 0 comments
Closed

EVM Engineering: Change CI pattern for contracts checks #11722

mds1 opened this issue Sep 3, 2024 · 0 comments
Assignees
@smartcontracts

Comments

@mds1
Copy link
Contributor

mds1 commented Sep 3, 2024

From #11677 (comment):

I never liked this echo "export INTERFACES_STATUS=1" >> "$BASH_ENV" pattern, and contributors less familiar with the codebase sometimes seem confused by it and are unsure what exactly failed.

I'd prefer to just fail the step directly, and change the workflow settings so all checks run even when previous ones fail

cc @smartcontracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smartcontracts smartcontracts

Labels
None yet
Projects
EVM Engineering
Status: Done
Proofs team - Project Delivery tracking board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smartcontracts @mds1