Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM Engineering: reduce number of flakes merged into CI #11738

Closed
smartcontracts opened this issue Sep 4, 2024 · 0 comments · Fixed by #11748
Closed

EVM Engineering: reduce number of flakes merged into CI #11738

smartcontracts opened this issue Sep 4, 2024 · 0 comments · Fixed by #11748
Assignees

Comments

@smartcontracts
Copy link
Contributor

We've seen a number of disruptive flakes being merged into CI lately. Flakes are most disruptive when they happen with a high probability. If we say that a flake probability of 5% is considered "disruptive" then we want to make sure that tests that will typically flake at a probability of 5% (with 512 fuzz runs) then we can reduce the number of disruptive flakes significantly by increasing the number of CI runs on merge ONLY when a new fuzz test is added.

Assuming that the probability of catching a flake is the same on every fuzz test run, some basic probability math shows that setting the fuzz runs to 512 * 90 = 46080 when a new fuzz test is added will catch an error with 99% probability.

Making this change will increase CI time only when adding new fuzz tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant