Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CursorQueue abstraction #12926

Open
sebastianst opened this issue Nov 14, 2024 · 0 comments
Open

CursorQueue abstraction #12926

sebastianst opened this issue Nov 14, 2024 · 0 comments
Assignees
Labels
A-op-batcher Area: op-batcher

Comments

@sebastianst
Copy link
Member

In #12390, the batcher got refactored to work with cursors on queues of blocks, channels and frames. Since the cursor and queue are manipulated together and consistent state between the two should be maintained, we could add a CursorQueue abstract to keep the consistency by design.

Originally posted by @sebastianst in #12390 (comment)

We may consider adding a CursorQueue abstraction that is a Queue with a cursor and then use it for blocks and frames. This way, we can better unit test the invariants between the queue and cursor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-batcher Area: op-batcher
Projects
None yet
Development

No branches or pull requests

2 participants