Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txmgr: use sendAsync in Queue #12947

Closed
geoknee opened this issue Nov 18, 2024 · 0 comments · Fixed by #13120
Closed

txmgr: use sendAsync in Queue #12947

geoknee opened this issue Nov 18, 2024 · 0 comments · Fixed by #13120
Labels
A-op-batcher Area: op-batcher

Comments

@geoknee
Copy link
Contributor

geoknee commented Nov 18, 2024 

          For a follow up, we need to fix the `txmgr.Queue` to use `TxMgr.SendAsync`, or just use `SendAsync` directly, because we need to lock in the nonce at the point we submit the transaction. This should also have been fixed before Holocene, but with the strict ordering requirements, this becomes more important.

Originally posted by @sebastianst in #12390 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-op-batcher Area: op-batcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

txmgr: Queue.Send() uses q.txMgr.SendAsync ethereum-optimism/optimism
1 participant
@geoknee