Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calldata Cost Reduction Checklist #1841

Closed
4 tasks
tynes opened this issue Dec 1, 2021 · 0 comments
Closed
4 tasks

Calldata Cost Reduction Checklist #1841

tynes opened this issue Dec 1, 2021 · 0 comments

Comments

@tynes
Copy link
Contributor

tynes commented Dec 1, 2021

There have been some recent proposals to reduce the gas cost of calldata which would allow for rollups to be cheaper. The L1 portion of the fee (used to cover batch submission) is charged along with the L2 portion of the fee (used to cover L2 execution).

These changes would cause the GasPriceOracle predeploy to overcharge for the L1 gas price, since the calldata costs are hardcoded in the contract. This means that we need to upgrade the GasPriceOracle contract once this change goes into place. Currently, there is no proxy in front of the GasPriceOracle - perhaps the GasPriceOracleV2 should be deployed behind a proxy so that it is upgradable. See here for the implementation of how the L1 portion of the fee is currently computed.

In the meantime, the price discrepancy can be handled by setting the scalar or overhead values lower.

TODOs:

  • Determine if using a proxy is the correct approach in the future
  • Write the GasPriceOracleV2 contract, which should be similar in functionality
  • Hardfork/squash fork logic will be required to switch to the new GasPriceOracleV2
  • Determine the correct values for the scalar and overhead to compensate for the cheaper calldata costs
@tynes tynes closed this as completed Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant