Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

[bug, feature] Stagnant bot shouldn't mention EIP Editors. #13

Closed
MicahZoltu opened this issue Sep 7, 2021 · 6 comments
Closed

[bug, feature] Stagnant bot shouldn't mention EIP Editors. #13

MicahZoltu opened this issue Sep 7, 2021 · 6 comments

Comments

@MicahZoltu
Copy link
Contributor

The EIP Editors don't need to take any action when the bot alerts of a stagnant EIP. The authors need to be notified so they can override but the editors don't have any action to take so they shouldn't be mentioned.

@MicahZoltu
Copy link
Contributor Author

The issue here is that the merge bot is piping up on the stagnant EIPs. Ideally it would skip over those.

@lightclient
Copy link
Member

It also seems like it require editor approval too? This should auto merge after some grace period I think.

@poojaranjan
Copy link

I am blanking if a grace period is already decided, if not, it could be up to 2 weeks (inspired by the "Last Call").

It would be nice to have the message delivered in the original message to the author that the EIP author has 2 weeks time to resuscitate the proposal.

image

@alita-moore
Copy link
Contributor

editors are removed by 92f5c11

what's the consensus on grace period? cc @MicahZoltu @lightclient @poojaranjan

@MicahZoltu
Copy link
Contributor Author

Two weeks is fine with me.

@alita-moore
Copy link
Contributor

ok, that behavior is defined here: 6ca2786

@alita-moore alita-moore changed the title Stagnant bot shouldn't mention EIP Editors. [bug, feature] Stagnant bot shouldn't mention EIP Editors. Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants