-
Notifications
You must be signed in to change notification settings - Fork 37
[feature] changes to final PRs should first mention authors, then editors after author approval. #20
Comments
Is this only for final PRs or is it okay to implement this for everything? Might be easier that way |
For changes to non-final EIPs that don't touch the status field, once the author approves the PR is automerged, no editor involvement. For changes that change the status or touch a final EIP, it should get author approval first (if the PR author isn't on the EIP authors list), and then after it is author approved it would prompt for editor approval. |
mainly I'm just referring to any case that prompts for editor, should it do it in a step-by-step manner like you mentioned? |
Ideally, yes. No point in getting editors involved prior to getting the necessary author approvals. |
this is accomplished via 4c2fb48 |
When someone submits a PR to change a final EIP, the bot should first @mention the authors. Once the author has approved the PR (or if the PR author is an author on the EIP) it should then @mention the editors for review.
Right now it appears to skip straight to mentioning the editors, and does not attempt to contact the authors at all.
The text was updated successfully, but these errors were encountered: