Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

[feature] changes to final PRs should first mention authors, then editors after author approval. #20

Closed
MicahZoltu opened this issue Sep 29, 2021 · 5 comments

Comments

@MicahZoltu
Copy link
Contributor

When someone submits a PR to change a final EIP, the bot should first @mention the authors. Once the author has approved the PR (or if the PR author is an author on the EIP) it should then @mention the editors for review.

Right now it appears to skip straight to mentioning the editors, and does not attempt to contact the authors at all.

@alita-moore
Copy link
Contributor

Is this only for final PRs or is it okay to implement this for everything? Might be easier that way

@MicahZoltu
Copy link
Contributor Author

For changes to non-final EIPs that don't touch the status field, once the author approves the PR is automerged, no editor involvement. For changes that change the status or touch a final EIP, it should get author approval first (if the PR author isn't on the EIP authors list), and then after it is author approved it would prompt for editor approval.

@alita-moore
Copy link
Contributor

mainly I'm just referring to any case that prompts for editor, should it do it in a step-by-step manner like you mentioned?

@MicahZoltu
Copy link
Contributor Author

mainly I'm just referring to any case that prompts for editor, should it do it in a step-by-step manner like you mentioned?

Ideally, yes. No point in getting editors involved prior to getting the necessary author approvals.

@alita-moore alita-moore changed the title Changes to final PRs should first mention authors, then editors after author approval. [feature] changes to final PRs should first mention authors, then editors after author approval. Oct 24, 2021
@alita-moore
Copy link
Contributor

this is accomplished via 4c2fb48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants