Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Set created date in the preamble immediately before merging new EIP pull requests #65

Open
SamWilsn opened this issue Apr 20, 2022 · 9 comments
Labels
enhancement New feature or request priority: low

Comments

@SamWilsn
Copy link

Originally from #55

Immediately before merging (IMO, ideally in the merge commit itself) set the created date in the preamble.

@JEAlfonsoP
Copy link
Contributor

I will PR this issue in the new FORK with a specific branch.

@MicahZoltu
Copy link
Contributor

You shouldn't be creating a new fork for every change. You want one fork with many branches.

@JEAlfonsoP
Copy link
Contributor

Thanks, this was before I deleted the FORk (one). I absolutely agree with you, that the new Fork (two), with a Branch for each Issue / PR is cleaner and simpler. Any idea or suggestion just shoot, I am here to learn and contribute.

@Pandapip1 Pandapip1 added enhancement New feature or request priority: low labels Aug 10, 2022
@JEAlfonsoP
Copy link
Contributor

I believe this was closed by Sam before ?

@Pandapip1
Copy link
Member

Nope?

@JEAlfonsoP
Copy link
Contributor

I will take a look on it.

@JEAlfonsoP
Copy link
Contributor

EIP 1 template:

eip:
title: <The EIP title is a few words, not a complete sentence>
description: <Description is one full (short) sentence>
author: <a comma separated list of the author's or authors' name + GitHub username (in parenthesis), or name and email (in angle brackets).
discussions-to:
status: Draft
type: <Standards Track, Meta, or Informational>
category (*only required for Standards Track): <Core, Networking, Interface, or ERC>
created: <date created on, in ISO 8601 (yyyy-mm-dd) format>
requires (*optional): <EIP number(s)>

Where do you want to include the created date ?

@Pandapip1
Copy link
Member

Just a warning: I am making a separate tool to handle things like this. You're probably going to want to hold off on this, #64, and #66

@JEAlfonsoP
Copy link
Contributor

Ok. Thanks for letting me know. I will pass on this one till you mention something else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request priority: low
Projects
None yet
Development

No branches or pull requests

4 participants