Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

[feature] Mention different editors for different types of EIPs #7

Closed
alita-moore opened this issue Jul 25, 2021 · 9 comments
Closed
Labels
enhancement New feature or request

Comments

@alita-moore
Copy link
Contributor

as mentioned by @MicahZoltu it would be good to mention different sets of editors based on what the type of eip is being considered.

@alita-moore
Copy link
Contributor Author

@MicahZoltu do you want to do this hardcoded or is there a way to determine what kind of eip it is automatically?

@alita-moore alita-moore changed the title [Feature] Mention different editors for different types of EIPs [feature] Mention different editors for different types of EIPs Jul 25, 2021
@alita-moore alita-moore added the enhancement New feature or request label Jul 25, 2021
@MicahZoltu
Copy link
Contributor

The EIP metadata has the EIP type in it. Core, Networking, Interface, etc. Which editors pay attention to which EIP types will have to be hard coded somewhere, similar to the list of EIP editors (maybe the same list, but with additional per-editor data).

@alita-moore
Copy link
Contributor Author

What is / where can I find the relevant people per type?

@MicahZoltu
Copy link
Contributor

This is an excellent question. At the least, Micah on Core EIPs and Lightclient on ERCs. I'm not sure how to distribute the rest.

@alita-moore
Copy link
Contributor Author

I'll just default others to all

@alita-moore
Copy link
Contributor Author

@MicahZoltu I'm doing this today, are there any developments on procuring a list of appropriate people to mention? Also, if it's helpful I can implement this as an input for the bot so it's easier to change

@MicahZoltu
Copy link
Contributor

It would be nice to have it be an input that can be configured easily without having to publish a new version of the bot.

Perhaps the initial implementation can just put all of the editors on everything except for me, and have everyone including me on the Core EIPs category. If configuration is easy then people can just submit a PR to remove themselves from one or both lists if they want.

@alita-moore
Copy link
Contributor Author

Okay, I'll do that

@alita-moore
Copy link
Contributor Author

This is completed by 310fd6c...950d79d

to change the editors you just have to edit the auto-merge-bot.yml with new names https://github.com/ethereum/EIPs/blob/master/.github/workflows/auto-merge-bot.yml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants