Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is the auto-merger maintained and run? #1831

Closed
bmann opened this issue Mar 6, 2019 · 7 comments
Closed

Where is the auto-merger maintained and run? #1831

bmann opened this issue Mar 6, 2019 · 7 comments

Comments

@bmann
Copy link
Contributor

bmann commented Mar 6, 2019

Where is the auto-merger code maintained and who / where is it run?

Can we help in improving the code and improve its operation so that “pinging people in Gitter” isn’t how to file that’s it down? Installing monitoring that notifies people that can fix it might be a first step.

Cc @axic

@bmann
Copy link
Contributor Author

bmann commented Mar 6, 2019

@Arachnid Arachnid closed this as completed Mar 6, 2019
@bmann
Copy link
Contributor Author

bmann commented Mar 6, 2019

I’d like to see the AM be more reliable / have less intervention and document who and how to talk to someone if it goes down, so no one is a single point of failure.

Are you open to this @Arachnid?

@Arachnid
Copy link
Contributor

Arachnid commented Mar 7, 2019

@bmann Sure! What did you have in mind, concretely?

@bmann
Copy link
Contributor Author

bmann commented Mar 7, 2019

Figuring out where to document this — maybe in the README for this repo? — and having st least two people who can “kick the automerger”.

If we can improve it so it breaks less that would be good too.

@Arachnid
Copy link
Contributor

Arachnid commented Mar 7, 2019

Not sure what "kicking" it involves?

The only issue I'm aware of is a race condition; sometimes the automerger gets pinged by Travis announcing the build succeeded before Travis pings Github, and so fails to merge because Github doesn't yet know the build succeeded. I haven't found a good way around this; a kludgy solution would be to add a fixed delay before checking Github.

Anyone can prod the automerger to reconsider a PR by going to http://ethlab-183014.appspot.com/merge/?repo=ethereum/eips&pr=1234.

@bmann
Copy link
Contributor Author

bmann commented Mar 8, 2019

Great, thank you -- I think that's enough for anyone can prod their own PRs now!

I have documented this on a new Infrastructure page on the Ethereum wiki: https://en.ethereum.wiki/infrastructure

@axic
Copy link
Member

axic commented May 1, 2019

Documented some of this in the readme with #1977.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@Arachnid @axic @bmann and others