Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Required Approvals #5651

Closed
Pandapip1 opened this issue Sep 13, 2022 · 15 comments
Closed

Dynamic Required Approvals #5651

Pandapip1 opened this issue Sep 13, 2022 · 15 comments
Labels
e-consensus Waiting on editor consensus enhancement r-ci Relates to the CI r-process Relates to an EIP Process w-stale Waiting on activity

Comments

@Pandapip1
Copy link
Member

My recommendation was to have changes to non-EIPs require a decreasing number of approvals based on how long they have been open. Something like:

1 week: 5 approvals
2 weeks: 4 approvals
4 weeks: 3 approvals
8 weeks: 2 approvals
16 weeks: 1 approval
and a single rejection would prevent auto-merging.

The idea here is that if there is consensus among all editors then things would go through quickly and smoothly. If, however, there aren't enough actively engaging editors then system doesn't permanently freeze/halt, it just slows down.

Originally posted by @MicahZoltu in #5640 (comment)

My suggestion is a little bit more general. If all editors approve, then a change gets instantly merged. If an editor approves, it starts a one-month countdown before it is automatically merged. If subsequent editors approve, it halves that countdown. A "request changes" review pauses this countdown.
@Pandapip1 Pandapip1 added enhancement r-process Relates to an EIP Process r-ci Relates to the CI e-consensus Waiting on editor consensus labels Sep 13, 2022
@poojaranjan poojaranjan mentioned this issue Sep 21, 2022
Closed
9 tasks
@xinbenlv
Copy link
Contributor

Sounds reasonable. Maybe a function of 5- log(2, week)?

@poojaranjan poojaranjan mentioned this issue Oct 19, 2022
Closed
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Jan 26, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 3, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 5, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 13, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 14, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 21, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 23, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 2, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 4, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 12, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 15, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 23, 2023
@Pandapip1
Copy link
Member Author

I think the consensus was that this is a good idea if it can be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e-consensus Waiting on editor consensus enhancement r-ci Relates to the CI r-process Relates to an EIP Process w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xinbenlv @Pandapip1 and others