-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow external links when archived link provided #5733
Comments
+1 from me. I suggested earlier that the archiving could even be done automatically by a bot that automatically points them to the archived version when the link rots. Copyright issues are nonexistent because this definitely falls under fair use. |
Great. #5408 is aligned with this purpose. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
I think the consensus is that this is a good idea. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
Dismissing bot |
We should differentiate between user requested links and crawled -- each link has to be intentionally added through a service like https://perma.cc Additionally an allowlist of acceptable providers should be considered, along with prohibition of links needing user maintenance like ipfs pinning (not as a primary link maybe?) More crucially having the possibility of now linking cross repo with the specs etc provides an opportunity to revisit front matter possibly. Yea no URL shortening either, really the links need to be served by the domain, cant have an additional layer of abstraction like url shortening services or ipfs addressing. Example is with git.io -- github has shut down their url shortening service and now links may be useless. |
I was specifically suggesting that a copy be kept in the assets folder. Sites like archive.org and perma.cc are still susceptible to being taken down. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
perma.cc provides a png of the entire site and a web bundle, which is a w3c standard for archiving sites. A full screen capture as an image is the most robust and easiest way to save said site. Additionally whatever folder holds the assets for that specific eip it may be advantageous to also provide a citations within that folder (though not included in the eip itself). arxiv.org has a similar setup for submitted papers: a pdf is made available and through a separate link a zip file of the raw submitted files (images, individual latex files, everything to be able to reproduce the pdf in high quality) |
I would additionally like to support https://github.com/mozilla/readability as a website download method, which takes the main page content and strips the formatting. |
External references should only be allowed if they refer to the ethereum spec itself, other EIPs, or a certain block in the agreed-upon branch of the ETH blockchain |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
Dismissing stale bot. @SamWilsn I can't remember if we've got a consensus on this. Have we? |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
Dismissing stale bot. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
Dismissing bot. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
Dismissing bot. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
Dismissing bot. |
I'm generally a +1 to this as well. @Pandapip1 I'm not as familiar with Mozilla's Readability. Does this strip the header information as well? This information is useful for fragmented linking to particular portions of a document. |
It does not strip the header info, unless I am mistaken. |
Sweet, no concerns from me on something like this then. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
I guess the best way to get this to occur is by submitting a PR. |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
Whats the status on this, can we bring this forward during office hours? |
Not during office hours; EIP-1 changes are for the EIPIP meeting |
There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity. |
I think that we established at some point that this is okay. Closing and making a PR. |
Proposed Change
An errata field with external links that are archived would prevent linking to broken sites, etc.
The text was updated successfully, but these errors were encountered: