Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external links when archived link provided #5733

Closed
sambacha opened this issue Sep 30, 2022 · 38 comments
Closed

Allow external links when archived link provided #5733

sambacha opened this issue Sep 30, 2022 · 38 comments
Labels
enhancement r-ci Relates to the CI r-process Relates to an EIP Process w-stale Waiting on activity

Comments

@sambacha
Copy link
Contributor

Proposed Change

An errata field with external links that are archived would prevent linking to broken sites, etc.

@Pandapip1
Copy link
Member

+1 from me. I suggested earlier that the archiving could even be done automatically by a bot that automatically points them to the archived version when the link rots. Copyright issues are nonexistent because this definitely falls under fair use.

@xinbenlv
Copy link
Contributor

xinbenlv commented Oct 4, 2022

Great. #5408 is aligned with this purpose.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 5, 2022
@Pandapip1
Copy link
Member

I think the consensus is that this is a good idea.

@github-actions github-actions bot removed the w-stale Waiting on activity label Dec 7, 2022
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 16, 2022
@Pandapip1
Copy link
Member

Dismissing bot

@github-actions github-actions bot removed the w-stale Waiting on activity label Dec 17, 2022
@sambacha
Copy link
Contributor Author

We should differentiate between user requested links and crawled -- each link has to be intentionally added through a service like https://perma.cc

Additionally an allowlist of acceptable providers should be considered, along with prohibition of links needing user maintenance like ipfs pinning (not as a primary link maybe?)

More crucially having the possibility of now linking cross repo with the specs etc provides an opportunity to revisit front matter possibly.

Yea no URL shortening either, really the links need to be served by the domain, cant have an additional layer of abstraction like url shortening services or ipfs addressing. Example is with git.io -- github has shut down their url shortening service and now links may be useless.

@Pandapip1
Copy link
Member

I was specifically suggesting that a copy be kept in the assets folder. Sites like archive.org and perma.cc are still susceptible to being taken down.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Jan 6, 2023
@sambacha
Copy link
Contributor Author

sambacha commented Jan 6, 2023

I was specifically suggesting that a copy be kept in the assets folder. Sites like archive.org and perma.cc are still susceptible to being taken down.

perma.cc provides a png of the entire site and a web bundle, which is a w3c standard for archiving sites.

A full screen capture as an image is the most robust and easiest way to save said site.

Additionally whatever folder holds the assets for that specific eip it may be advantageous to also provide a citations within that folder (though not included in the eip itself).

arxiv.org has a similar setup for submitted papers: a pdf is made available and through a separate link a zip file of the raw submitted files (images, individual latex files, everything to be able to reproduce the pdf in high quality)

@Pandapip1
Copy link
Member

I would additionally like to support https://github.com/mozilla/readability as a website download method, which takes the main page content and strips the formatting.

@Pandapip1 Pandapip1 added r-ci Relates to the CI r-process Relates to an EIP Process and removed w-stale Waiting on activity labels Jan 6, 2023
@erkinalp
Copy link

erkinalp commented Jan 8, 2023

External references should only be allowed if they refer to the ethereum spec itself, other EIPs, or a certain block in the agreed-upon branch of the ETH blockchain

@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Jan 16, 2023
@Pandapip1
Copy link
Member

Dismissing stale bot.

@SamWilsn I can't remember if we've got a consensus on this. Have we?

@github-actions github-actions bot removed the w-stale Waiting on activity label Jan 17, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Jan 24, 2023
@Pandapip1
Copy link
Member

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 18, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 26, 2023
@Pandapip1
Copy link
Member

Dismissing bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 6, 2023
@Pandapip1
Copy link
Member

Dismissing bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 7, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 15, 2023
@Pandapip1
Copy link
Member

Dismissing bot.

@kdenhartog
Copy link
Contributor

I'm generally a +1 to this as well. @Pandapip1 I'm not as familiar with Mozilla's Readability. Does this strip the header information as well? This information is useful for fragmented linking to particular portions of a document.

@Pandapip1
Copy link
Member

Pandapip1 commented Mar 15, 2023

It does not strip the header info, unless I am mistaken.

@kdenhartog
Copy link
Contributor

Sweet, no concerns from me on something like this then.

@github-actions github-actions bot removed the w-stale Waiting on activity label Mar 16, 2023
@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Mar 24, 2023
@Pandapip1
Copy link
Member

I guess the best way to get this to occur is by submitting a PR.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Apr 6, 2023
@sambacha
Copy link
Contributor Author

Whats the status on this, can we bring this forward during office hours?

@github-actions github-actions bot removed the w-stale Waiting on activity label May 14, 2023
@Pandapip1
Copy link
Member

Not during office hours; EIP-1 changes are for the EIPIP meeting

@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label May 24, 2023
@Pandapip1
Copy link
Member

I think that we established at some point that this is okay. Closing and making a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement r-ci Relates to the CI r-process Relates to an EIP Process w-stale Waiting on activity
Projects
None yet
Development

No branches or pull requests

6 participants
@xinbenlv @erkinalp @kdenhartog @sambacha @Pandapip1 and others