Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft background image to draft EIPs #6479

Closed
Pandapip1 opened this issue Feb 9, 2023 · 14 comments
Closed

Add draft background image to draft EIPs #6479

Pandapip1 opened this issue Feb 9, 2023 · 14 comments
Labels
e-consensus Waiting on editor consensus enhancement r-process Relates to an EIP Process r-website Relates to the Website w-stale Waiting on activity

Comments

@Pandapip1
Copy link
Member

Pandapip1 commented Feb 9, 2023

Proposed Change

A concern people have had about auto merging draft EIPs without editor review (#5641) was that they might be low quality, and might reflect poorly on EIPs as a whole. Therefore, to enable this change to happen, I propose this be added as a tiled background image on all Draft EIPs:

draftv2.png

@Pandapip1 Pandapip1 added enhancement r-website Relates to the Website r-process Relates to an EIP Process e-consensus Waiting on editor consensus labels Feb 9, 2023
@Pandapip1
Copy link
Member Author

Pandapip1 commented Feb 9, 2023

(Yes, this is a serious proposal, although the image can be tweaked if need be if there are legibility concerns)

@abcoathup
Copy link
Contributor

abcoathup commented Feb 10, 2023

I don't mind a DRAFT watermark.

If you go down this path should also have watermarks to warn of any state a reader should be on the alert for when reading a standard, e.g. WITHDRAWN and STAGNANT.

I would also keep it simple as just DRAFT

@SamWilsn
Copy link
Contributor

Completely agree with @abcoathup. Just the status, lightly watermarked, except for final.

@github-actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Jul 20, 2023
@Pandapip1
Copy link
Member Author

@lightclient @axic @gcolvin thoughts?

@github-actions github-actions bot removed the w-stale Waiting on activity label Jul 22, 2023
@lightclient
Copy link
Member

This implies that other EIPs are peer reviewed 😬. It just seems unnecessary. I would rather they get a draft identifier instead like DEIP-XXXX.

@Pandapip1
Copy link
Member Author

This implies that other EIPs are peer reviewed 😬.

Are the editors not peers?

@Pandapip1
Copy link
Member Author

I would rather they get a draft identifier instead like DEIP-XXXX.

Same here! If I had to pick between one or the other, I would pick draft identifiers.

However, we are lucky enough to be able to be able to support both! Even though you feel it is unnecessary, are you at all opposed to its implementation?

@lightclient
Copy link
Member

Yes I strongly don't think we should watermark.

@Pandapip1
Copy link
Member Author

Yes I strongly don't think we should watermark.

Fair enough. I'll leave this open in case other editors strongly disagree with lightclient here, but I'm okay with letting this die out.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 2, 2023
@SamWilsn
Copy link
Contributor

Yes I strongly don't think we should watermark.

Why @lightclient? I think a subtle watermark of "Draft", "Review", "Last Call", or "Withdrawn" would be great.

The "non peer-reviewed" part is probably misleading, like you mentioned.

@github-actions github-actions bot removed the w-stale Waiting on activity label Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 8, 2023
@github-actions
Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus enhancement r-process Relates to an EIP Process r-website Relates to the Website w-stale Waiting on activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@lightclient @abcoathup @Pandapip1 @SamWilsn and others