-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP712, motivates switching chain for signing #8610
Comments
Confirma |
@Aniket965, welcome to EIP repo. Thank you for post. QQ: this is a technical comment on EIP-712, can you post it on Ethereum Magician? If you have difficulty posting it on Ethereum Magician please let us know. (I'd also suggest you clarify "this behaviour can be changed" what is required here) |
hey @Aniket965 , yeah this will be closed as off-topic. eth-magicians is powered by Discourse, which by default doesn't let brand-new users post new threads. Check your inbox for instructions, all new users get a message like this explaining the rules: Your question sounds like it might actually be a question for metamask or viem, tho, I'm not sure EIP712 has any opinion about network connections (which should be on a lower layer?) |
Definitely a question for the Wallet. |
@jxom sorry to trigger your google alert here, i was just throwing out ideas at random not really understanding the question 🙈 |
thank you, make sense |
Pull Request
No response
What happened?
first of all sorry i know its not a bug, but i am not able to create post on ethereum magician portal so made it here ,feel free to close it.
EIP712, introduced
eth_signTypedData
which takes on typed data, this method is used by wallets and they show nice ui where they show this typedData to user, this make easier for user to undestand what they are signing.problem is when they have to sign it they have to switch to that chain although i dont see a very clear point why they have to do it eip712 takes domain seperater which have chainId, which makes it a chain specific signature which is good but it only takes chainId which should not require connecting to that chain.
it is possible to sign eip712 message without switching chain but rn do which means finding message hash of this signedTypeData and aksing user to sign it, the wallet doesnt show typed data ui for it. i think EIP712 motivates wallets to use
eth_signTypedData
so they implements it that way. it will be good if this behaviour can be changedRelevant log output
No response
The text was updated successfully, but these errors were encountered: