Add ERC: Wallet Call Token Capabilities #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eip-review-bot
changed the title
abcoathup
reviewed
Oct 22, 2024
abcoathup
reviewed
Oct 22, 2024
ScreamingHawk
force-pushed
the
tx-intents
branch
from
28fff5b to
fa05264
Compare
Deluaney1
reviewed
Nov 6, 2024
eip-review-bot
changed the title
eip-review-bot
changed the title
ScreamingHawk
force-pushed
the
tx-intents
branch
from
6fe45bb to
fd11f4c
Compare
Roseymr
approved these changes
Dec 1, 2024
SamWilsn
reviewed
Dec 6, 2024
ERCS/erc-7795.md
Outdated
|
|
||
| In this scenario, the wallet **MAY** prompt the user to sign the necessary transactions to fulfill the requirements before proceeding with the main transaction. The wallet **SHOULD** compute possible solutions to meet the requirements and **MUST** ensure that these prerequisites are met prior to executing the main transaction. | ||
|
|
||
| ```mermaid |
There was a problem hiding this comment.
Our renderer does not support mermaid. Please include an image (preferably SVG) in your assets directory.
ERCS/erc-7795.md
Outdated
| 3. Independent versioning of requirement types | ||
| 4. Simpler implementation for basic wallets | ||
|
|
||
| ## Reference Implementation |
There was a problem hiding this comment.
The reference implementation section should contain a minimal example implementation of the standard, not usage examples. This content belongs in the specification section, especially considering it's introducing new requirements (with MUST/MAY/etc.)
ERCS/erc-7795.md
Outdated
|
|
||
| Users already trust their wallet provider to craft, manipulate and send transactions on their behalf. This ERC only adds a new field to the transaction request, which the wallet can use to make more informed decisions about transaction construction. | ||
|
|
||
| DApps **MAY** opt out of using this feature if they wish to handle requirement fulfillment themselves. |
There was a problem hiding this comment.
Requirements should only be introduced in the specification section.
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
|
The commit e49930c (as a parent of 9bbd734) contains errors. |
|
Thanks @SamWilsn ! 🙏 I've addressed all comments. Let me know if any further changes are required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ERC introduces a mechanism for dapps to provide prerequisites for transactions to smart contract wallets. Wallets can use these prerequisites to make more informed decisions about transaction construction.