Add ERC: Data Asset NFT #744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcoathup
reviewed
Nov 29, 2024
abcoathup
reviewed
Nov 29, 2024
rockiecn
force-pushed
the
data-asset-nft
branch
from
433be83 to
c5cf075
Compare
rockiecn
force-pushed
the
data-asset-nft
branch
from
c5cf075 to
7a83eb0
Compare
confirm change 7921 to 7829 Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
fix to 7829 in discussions-to Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
|
The commit b6f143d (as a parent of e5e3755) contains errors. |
SamWilsn
requested changes
Dec 17, 2024
| --- | ||
| eip: 7829 | ||
| title: Data Asset NFT | ||
| description: Bring Data Assets to NFTs and ensure the integrity of data asset NFTs through storage proof |
There was a problem hiding this comment.
Since "data asset" is already in the title, you could use your description to define what a data asset is.
|
|
||
| Furthermore, to reduce storage costs, the NFT content is generally stored off-chain (IPFS, S3) or cross-chain storage (Arweave), and the link of NFT content is saved on-chain. Off-chain users can access the NFT content by visiting the link. However, on-chain contracts can not access the link to determine the status of the data, such as data loss, data tampering, or data expiration. These situations can lead to the data deviating from its actual value, but the NFT still exists on the chain, and the underlying copyright is still being sold in the market. | ||
|
|
||
| This proposal introduces Data Asset NFTs, which solve the dilemma of on-chain data assets by combining a modular data layer--DA (Data Availability). |
There was a problem hiding this comment.
Suggested change
| This proposal introduces Data Asset NFTs, which solve the dilemma of on-chain data assets by combining a modular data layer--DA (Data Availability). | |
| This proposal introduces Data Asset NFTs, which solve the dilemma of on-chain data assets by combining a modular data layer--Data Availability (DA). |
|
|
||
| The keywords “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY” and “OPTIONAL” in this document are to be interpreted as described in RFC 2119. | ||
|
|
||
| ### Every compliant data permission contract must implement the Interface |
There was a problem hiding this comment.
Try to use shorter headings, and put the requirement in the body of the section.
| } | ||
| ``` | ||
|
|
||
| The metadata schema for Data Asset NFTs is as follows: |
There was a problem hiding this comment.
You should mention what format the schema is in.
| } | ||
| ``` | ||
|
|
||
| The Reader role should not involve changes in permissions, meaning that Readers cannot call functions such as Transfer, Approve, and SetReader. |
There was a problem hiding this comment.
Please put code snippets in backticks (`) throughout the document
|
|
||
| The Reader role should not involve changes in permissions, meaning that Readers cannot call functions such as Transfer, Approve, and SetReader. | ||
|
|
||
| When Alice calls the Transfer function to transfer one of Alice's Data Asset NFTs to Bob: |
There was a problem hiding this comment.
Do you mean transfer (lowercase)?
|
|
||
| ## Copyright | ||
|
|
||
| Copyright and related rights waived via CC0. |
There was a problem hiding this comment.
Please use the exact waiver from the EIP template.
There was a problem hiding this comment.
We prefer SVGs if you can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ERC outlines the minimally required interfaces and behavior for Data Asset NFT. It proposes a storage proof mechanism to ensure Data Asset NFT's integrity, and propose a new role, Reader, to Amplify Data Asset's value.