Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consuming /eth/v1/config/spec as VC #361

Open
Tracked by #364
tbenr opened this issue Sep 25, 2023 · 2 comments
Open
Tracked by #364

Consuming /eth/v1/config/spec as VC #361

tbenr opened this issue Sep 25, 2023 · 2 comments

Comments

@tbenr
Copy link
Contributor

tbenr commented Sep 25, 2023

We recently had some interoperability issues when new parameters has been introduced in the configuration.

As an example, when networking parameters has been promoted to configuration parameters caused VCs failing to start if upgraded before their BNs.

In Teku we recently merged a PR making the VC less choosy by following the new sequence when consuming /eth/v1/config/spec:

  1. load local known preset (as per PRESET_BASE)
  2. load local known config (as per CONFIG_NAME) [new]
  3. load remaining params from remote

By applying known config by looking up CONFIG_NAME, the final configuration is guaranteed to have all expected params.

Wrt additional unexpected param (ie. upgrade BN exposing new configs, restart previous VC version) we just print a warning ignoring unknown params.

How are other clients do? If we all agree on a common strategy we could avoid interoperability issues.

@Falehfale Falehfale mentioned this issue Sep 28, 2023
Closed
@rolfyone
Copy link
Collaborator

rolfyone commented Oct 1, 2023

We (teku) load config_name first, then preset, that's the order it was previously loaded... just in case anyone is following that ordering...

Consensys/teku#7510

@rolfyone
Copy link
Collaborator

rolfyone commented Oct 2, 2023

After discussion, I've ended up changing teku to no longer load the local config_name, and we're defaulting the constants that got moved Consensys/teku#7566
It could potentially hide some 'bad config', but the constants that were missing also stopped old config from loading, which is undesirable.

So basically teku when loading:

  • defaults networking 'constants' that got moved to config
  • will load preset
  • then will overlay the remote config onto that
  • ignores unknown values

in the/eth/v1/config/spec endpoint, we'll be pushing values like GOSSIP_MAX_SIZE (good example of a moved constant) and would hope they're read by the consumer, but at least I'd hope that consumers aren't failing if it's unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants