Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attestation related APIs to be compatible with EIP-7549 #445

Open
tbenr opened this issue Apr 26, 2024 · 6 comments · Fixed by #448
Open

Update attestation related APIs to be compatible with EIP-7549 #445

tbenr opened this issue Apr 26, 2024 · 6 comments · Fixed by #448

Comments

@tbenr
Copy link
Contributor

tbenr commented Apr 26, 2024

attestations for Electra require an additional committee_bits field.

I think these APIs are effected.
/eth/v1/beacon/pool/attestations
/eth/v1/beacon/blocks/{block_id}/attestations
/eth/v1/validator/aggregate_attestation

@tbenr tbenr mentioned this issue Apr 26, 2024
2 tasks
@rkapka
Copy link
Collaborator

rkapka commented Apr 27, 2024

Also /eth/v1/validator/aggregate_and_proofs

@ensi321
Copy link
Contributor

ensi321 commented Apr 29, 2024

Something minor but I believe attester slashing is affected because the max length of attesting_indices in IndexedAttestation is changed.
So get and post /eth/v1/beacon/pool/attester_slashings

@tersec
Copy link

tersec commented Apr 29, 2024

Would note that there's a conceptual difference in get/put type APIs. Both worth discussing, but adding polymorphism present challenges to different parts of the stack. The initial list of three all returns an Attestation-like structure for example, which implies a particular type system setup to handle that.

@tersec
Copy link

tersec commented May 2, 2024

https://ethereum.github.io/beacon-APIs/#/Events/eventstream has an attestation event type, potentially affected

@tbenr
Copy link
Contributor Author

tbenr commented May 3, 2024

I suspect we need to move /eth/v1/validator/aggregate_attestation to v2, 'cose committee index parameter is required to BN if we want to produce aggregates only for the committee the validator is in.
cc @mkalinin

@mkalinin
Copy link

mkalinin commented May 6, 2024

I suspect we need to move /eth/v1/validator/aggregate_attestation to v2, 'cose committee index parameter is required to BN if we want to produce aggregates only for the committee the validator is in. cc @mkalinin

Yes, the committee_index has to be passed explicitly onto this call, because the EIP tends to preserve the network part of the aggregation strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants