Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be great if we could clarify the types of the constants in the beacon chain "Misc" and other parts #1750

Closed
lucianyao opened this issue Apr 24, 2020 · 1 comment

Comments

@lucianyao
Copy link

in the beacon chain "Misc", "Rewards and penalties", etc, there are no type stated for the constants, I wonder if we could define the type for each constant, so as to avoid data conversion loss, though which looks not going to happen...

btw, in language like "Rust", the type of a vector index and count has to be "usize", which is u64 on 64 bits cpu, u32 on 32bits cpu. In my mind regarding java, it has to be an integer, which is always 32-bits.

@hwwhww
Copy link
Contributor

hwwhww commented Apr 24, 2020

#1746 would clarify the constants types.
Also, the overflow issue has been discussed in #1701.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants