-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode terminal total difficulty #2605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of small notes about config.
otherwise looks good!
will wait on #2581 to approve so the diff looks cleaner for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent!
nice! this is definitely cleaner. re: #2599, do you think it makes sense to have a param for |
Yes, I think this would be the right way to implement override of a terminal block. And if transition ends up with terminal block override then consensus and execution clients will need to be released with hardcoded terminal block hash. |
What's done?
TransitionStore
withcompute_terminal_total_difficulty
function are replaced withTERMINAL_TOTAL_DIFFICULTY
configuration parameterRationale
Dependencies
cc @ajsutton