Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove phase0-capella state transition tests from the test vector output #3634

Open
hwwhww opened this issue Mar 26, 2024 · 2 comments
Open

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Mar 26, 2024

The size of the total test vectors keeps growing. IMO we can remove the meaningless state transition tests from the test vectors output.

Note that these tests should still be run and verified in CI with minimal preset to ensure spec correctness.

@ralexstokes
Copy link
Member

looking into this...

@potuz
Copy link
Contributor

potuz commented Mar 28, 2024

As long as every single case (that is still applicable in later forks) is still covered in later forks that seems fine by me. We have found plenty of testvectors in forkchoice that were on specific forks or on specific presets and that actually didn't catch consensus bugs that would have been caught if the mainnet test vectors for the current fork were in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants